[
https://issues.apache.org/jira/browse/CASSANDRA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285276#comment-17285276
]
Sylvain Lebresne commented on CASSANDRA-16355:
----------------------------------------------
It sounds very plausible than 200ms is on the low end for CI, and [~blerer]
explanations of why timeouts would lead to the failure seen on this ticket make
sense.
So +1 for the patch raising the timeout. Maybe just a nit: I'd use the
opportunity for moving the timeout value into a constant.
That said, it's a bit unfortunate the test failures don't surface more clearly
that this is due to a timeout. The reason this happen, at least for
`incompletePropose` and if I understand correctly, is that while the initial
inserts timeout _before_ it was supposed to, the `catch` doesn't know that. So
what about modifying `IMessageFilters.Filter` so that it counts the number of
messages it drops? With that, we could check after that the first insert
timeout that the filter was triggered. And if it wasn't, that would imply we
timed out before we were supposed too (and we could have a message saying "Hey,
CI is slow again today").
But I do understand this imply a change and subsequent release of the in-jvm
dtest API, so I'd be fine committing the timeout bump now for the sake of
cleaning up CI and have that "improvement" in a followup (or not at all, it's
just a suggestion).
> Fix flaky test incompletePropose -
> org.apache.cassandra.distributed.test.CASTest
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-16355
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16355
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Lightweight Transactions, Test/dtest/java
> Reporter: David Capwell
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/853/workflows/0766c0de-956e-4831-aa40-9303748a2708/jobs/5030
> {code}
> junit.framework.AssertionFailedError: Expected: [[1, 1, 2]]
> Actual: []
> at
> org.apache.cassandra.distributed.shared.AssertUtils.fail(AssertUtils.java:193)
> at
> org.apache.cassandra.distributed.shared.AssertUtils.assertEquals(AssertUtils.java:163)
> at
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:63)
> at
> org.apache.cassandra.distributed.test.CASTest.incompletePropose(CASTest.java:124)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
