[
https://issues.apache.org/jira/browse/CASSANDRA-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294692#comment-17294692
]
Andres de la Peña commented on CASSANDRA-16444:
-----------------------------------------------
{quote}Regarding the timestamp fix, would it not make sense to use some thing
like rather than specifying the timestamp for each call to loadData?
{quote}
{quote}I actually have a slight preference for fixed timestamps as they produce
deterministic results. Using a counter means that you don't really control
which timestamps are being used. Besides, at least one test requires very
specific timestamps or it fails: {{testTruncate}}.
{quote}
I liked the idea of increasing the timestamp inside of {{loadData}}. I think
that, given that the tests are not run in parallel, that automatically
increased timestamp would also be deterministic. As for the special case of
{{testTruncate}} we can use the current behaviour overloading {{loadData}}.
Also I think there is no need to use seconds, we can increase the timestamps
one by one with a precision of milliseconds. I gave it a go
[here|https://github.com/adelapena/cassandra/commit/fbcef9b9e0bd81a9101682e8bd1ffabe776cba5f].
Nevertheless this is just a detail so feel free to ignore if you don't agree.
Other than this nit, the changes look good to me, it's nice to see this test
finally fixed.
> Fix flaky test testMultiExpressionQueriesWhereRowSplitBetweenSSTables -
> org.apache.cassandra.index.sasi.SASIIndexTest
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16444
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16444
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: David Capwell
> Assignee: Alexandre Dutra
> Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/862/workflows/d2b10373-5bd1-4895-a738-1c28587cae62/jobs/5136
> {code}
> junit.framework.AssertionFailedError: []
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:589)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:468)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
