[ 
https://issues.apache.org/jira/browse/CASSANDRA-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295135#comment-17295135
 ] 

Benjamin Lerer commented on CASSANDRA-16444:
--------------------------------------------

{quote}Do we need to worry about it? From my (admittedly novice) standpoint, it 
seems that AbstractType has stricter validation rules in 3.11 than in 
4.0...{quote}

According to [~slebresne] 
[comment|https://issues.apache.org/jira/browse/CASSANDRA-15778?focusedCommentId=17117827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17117827]
 the validation was only added because he believe that the new code could 
trigger this path.

In my opinion the validation make sense anyway so it might be good to put it 
also in 4.0. I would just use some proper IOException like in {{readValue}} 
rather than assertions.   

> Fix flaky test testMultiExpressionQueriesWhereRowSplitBetweenSSTables - 
> org.apache.cassandra.index.sasi.SASIIndexTest
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16444
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16444
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: Alexandre Dutra
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/862/workflows/d2b10373-5bd1-4895-a738-1c28587cae62/jobs/5136
> {code}
> junit.framework.AssertionFailedError: []
>       at 
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:589)
>       at 
> org.apache.cassandra.index.sasi.SASIIndexTest.testMultiExpressionQueriesWhereRowSplitBetweenSSTables(SASIIndexTest.java:468)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to