[
https://issues.apache.org/jira/browse/CASSANDRA-16516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302503#comment-17302503
]
Andres de la Peña commented on CASSANDRA-16516:
-----------------------------------------------
The patch generating the slices according to the generated byte array looks
good to me, that way we don't miss any of the generated examples.
Maybe the method {{ValueAccessor#slices}} could be {{private}} and return
directly, without declaring and immediately return {{gen}}:
{code:java}
private static Gen<ByteArraySlice> slices(Gen<byte[]> arrayGen)
{
return td -> {
{code}
I have also successfully run the test locally a few thousand times.
[Here|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/706/]
are 1000 runs of the method in our multiplexer, and
[here|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/707/]
are 100 runs of the full suite.
> ValueAccessorTest.testSlice is flaky
> ------------------------------------
>
> Key: CASSANDRA-16516
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16516
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Brandon Williams
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-devbranch/479/testReport/junit/org.apache.cassandra.db.marshal/ValueAccessorTest/testSlice/
> Probably fairly rare, but the potential is there:
> {quote}
> Regression
> org.apache.cassandra.db.marshal.ValueAccessorTest.testSlice
> Failing for the past 1 build (Since In progress#479 )
> Took 25 ms.
> Error Message
> Gave up after finding only 59 example(s) matching the assumptions
> Stacktrace
> java.lang.IllegalStateException: Gave up after finding only 59 example(s)
> matching the assumptions
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
