[
https://issues.apache.org/jira/browse/CASSANDRA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304047#comment-17304047
]
Sam Tunnicliffe commented on CASSANDRA-15148:
---------------------------------------------
Hi [~e.dimitrova]
I think that you're seeing that error because {{InetAddressAndPort}} isn't
properly serializable, despite it being marked as such. Other tests which need
to pass {{IAAP}} to test instances use {{InetSocketAddress}} and a helper
function to convert on the the target. I've pushed [a
commit|https://github.com/apache/cassandra/commit/37140e2476d2a23f10937c1e9895df7952f548cb]
which does that in {{GossipTest}} and I no longer see the errors.
The test itself still fails though (actually times out), because the {{late}}
instance never receives the {{MOVING}} state for the {{fail}} instance. This is
down to a difference in implementation of {{Instance::shutdown}} between trunk
and earlier branches. In a non-graceful shutdown, the messaging service needs
to be abruptley stopped before the shutting down instance has chance to
broadcast a gossip shutdown message to live peers. This was not happening on
trunk, so the remaining live instance (node1) would receive the message and
update the {{STATUS}} of node2 to {{SHUTDOWN}}, which was then being propagated
to node3. I've fixed that and the test passes for me locally now.
While I was at it, I've updated the wait conditions to check
{{STATUS_WITH_PORT}} as {{STATUS}} is now deprecated, but this wasn't strictly
necessary.
LMK what you think about these tweaks.
> Add in-jvm dtest for Gossip to trunk
> ------------------------------------
>
> Key: CASSANDRA-15148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15148
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java
> Reporter: Sam Tunnicliffe
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-rc
>
>
> When merging CASSANDRA-15120 to trunk, the in-jvm dtest support for gossip
> and networking were ommitted as much of the work to support that is already
> done and due to land in CASSANDRA-15066. Once that patch is committed, we
> should add the {{GossipTest}} from CASSANDRA-15120 to trunk.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
