[ https://issues.apache.org/jira/browse/CASSANDRA-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305229#comment-17305229 ]
Ekaterina Dimitrova commented on CASSANDRA-15148: ------------------------------------------------- Actually, considering you debugged it while I was sleeping in my time zone, I set you as an author as I believe that is fair. :) I wrapped it [here |https://github.com/ekaterinadimitrova2/cassandra/commit/3db3e2a9a7cb0c7bc6c36654003c81b292c01613] and marking myself as a reviewer. +1 from me :D LMK what you think. {quote}bq. I am planning to change it also in the other tests as part of this ticket, not only for this test, WDYT? {quote} I decided to leave this out of the scope of this ticket as it seems there are a lot of occurrences and not all of them should be directly changed; careful revision should be done not only in the test framework but also in the actual product source. Pushing CircleCI run [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=15148] > Add in-jvm dtest for Gossip to trunk > ------------------------------------ > > Key: CASSANDRA-15148 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15148 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/java > Reporter: Sam Tunnicliffe > Assignee: Ekaterina Dimitrova > Priority: Low > Fix For: 4.0, 4.0-rc > > > When merging CASSANDRA-15120 to trunk, the in-jvm dtest support for gossip > and networking were ommitted as much of the work to support that is already > done and due to land in CASSANDRA-15066. Once that patch is committed, we > should add the {{GossipTest}} from CASSANDRA-15120 to trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org