[
https://issues.apache.org/jira/browse/CASSANDRA-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312350#comment-17312350
]
Berenguer Blasi commented on CASSANDRA-16532:
---------------------------------------------
[~adelapena] scratch that. I was referring to a previous comment of yours about
moving the per-test init of those 2 params to the {{Before}} which I was
against as I preferred the per-test approach. Now I have re read your latest
comment about moving them to {{BeforeClass}} I think we're splitting hairs: you
can argue you need a {{Before/After}} pair if any test would alter those in
between, you can argue {{BeforeClass/AfterClass}} are better bc no test is
doing so _yet_, you can argue a per test approach is better as it doesn't add
noise to the other tests that don't need it,... pick your poison lol.
I prefer the per test approach but I don't feel strongly about it. I'd say we
merge as it is or I can do the {{BeforeClass}} one if you prefer.
> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --------------------------------------------------
>
> Key: CASSANDRA-16532
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16532
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Fix flaky
> [testSkipScrubCorruptedCounterRowWithTool|https://ci-cassandra.apache.org/job/Cassandra-trunk/365/testReport/junit/org.apache.cassandra.db/ScrubTest/testSkipScrubCorruptedCounterRowWithTool_compression/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
