[ 
https://issues.apache.org/jira/browse/CASSANDRA-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308766#comment-17308766
 ] 

Andres de la Peña commented on CASSANDRA-16532:
-----------------------------------------------

I suspect that those failures with {{testScrubOutOfOrder}} and compression are 
also related to the tests reusing the tables and calling {{clearUnsafe}}.

[In this 
commit|https://github.com/adelapena/cassandra/commit/b19711ac8d6f163113ba8f49762e2959996adfd7]
 I have tried to unify the two coexistent initialization methods 
({{defineSchema}} and {{toolTestingSetup}}) into a single method annotated with 
JUnit's {{@Begin}}. This way every test uses its own dedicated keyspace and we 
don't need the calls to {{clearUnsafe}}. I have also done some minor cleaning 
to reduce the number of tables per keyspace and to get rid of most of the 
warnings across {{ScrubTest}}.

With these changes it seems that the test suite passes 400 runs in the 
multiplexer with compression 
([here|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/737/]
 and 
[here|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/737/]),
 and 200 more runs without compression 
([here|https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/739/]).

> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --------------------------------------------------
>
>                 Key: CASSANDRA-16532
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16532
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-rc
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Fix flaky 
> [testSkipScrubCorruptedCounterRowWithTool|https://ci-cassandra.apache.org/job/Cassandra-trunk/365/testReport/junit/org.apache.cassandra.db/ScrubTest/testSkipScrubCorruptedCounterRowWithTool_compression/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to