[
https://issues.apache.org/jira/browse/CASSANDRA-16704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356586#comment-17356586
]
Michael Semb Wever commented on CASSANDRA-16704:
------------------------------------------------
bq. Though in terms of classpath, we're effectively back where we started since
instead of joining the compile and provided scopes from build/lib/ with the
test scope in build/test/lib/ we'd be joining the compile scope in lib/ with
the test and provided scopes in build/test/lib/.
Yeah, we have three separate concerns:
- compiling, requires compile and provided scopes,
- packaging, requires compile scope,
- testing, requires compile and test scopes, and sometimes provided/optional
scope.
I'm open to suggestions on how to tackle this, but not sure the current patch
to build.xml really puts us in a significantly better situation. The rest of
the patch LGTM!
bq. there's no need to duplicate dependencies across provided and test.
Shouldn't we be able to remove the test scoped duplicated lines then?
> Fix imports; run tests with packaged dependencies
> -------------------------------------------------
>
> Key: CASSANDRA-16704
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/burn, Test/unit
> Reporter: Angelo Polo
> Assignee: Angelo Polo
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: test-with-runtime-deps.patch
>
>
> Tests are currently run with a classpath containing _all_ downloaded jars.
> The tests would be more reflective of the behavior of a runtime environment
> if the test classpath only contained jars that are bundled with the binary
> release, together with explicit test dependencies. Ideally we'd use the
> build/lib/ jars for the classpath since that's what gets packaged, but since
> these aren't available at test compile time and should be identical to lib/
> anyway, I've used the later.
> Doing so exposed a couple of references in src/java to
> "org.apache.commons.lang", which is not available at runtime (should be
> "org.apache.commons.lang*3*").
> Attached patch modifies the test classpath, fixes various imports in both
> test/ and src/ classes, and makes some simple substitutions in the tests such
> as using AbstractMap.SimpleEntry in place of
> org.apache.commons.collections.keyvalue.AbstractMapEntry.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
