[
https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387295#comment-17387295
]
Aleksei Zotov commented on CASSANDRA-16806:
-------------------------------------------
{quote}{{DELETE}} operations are included in the {{PartitionUpdate}} that the
{{VirtualTable.apply}} method will receive so we do not need to change anything
at the statement level or in the interface.
{quote}
Actually there is a need for a small change on statement level:
{code:java}
checkFalse(metadata.isVirtual(), "Virtual tables don't support DELETE
statements");{code}
[https://github.com/apache/cassandra/blob/bf96367f4d55692017e144980cf17963e31df127/src/java/org/apache/cassandra/cql3/statements/DeleteStatement.java#L148]
Apart from that change, deletion from VTs needs to be covered by corresponding
tests as well as documentation needs to be updated. I have these changes ready.
We just need to decide whether we include them here or raise a separate ticket.
Please, let me know your thoughts.
> Allow TRUNCATE to work on Virtual Tables if the implementation allows it
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-16806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
> Reporter: Benjamin Lerer
> Assignee: Aleksei Zotov
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For
> some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}}
> interface and calling that method from {{TruncateStatement}}. The default
> implementation of the method should be to fire an {{InvalidRequestException}}
> saying that truncate is not supported on that specific table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
