[
https://issues.apache.org/jira/browse/CASSANDRA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404578#comment-17404578
]
Andres de la Peña commented on CASSANDRA-16871:
-----------------------------------------------
Thanks for looking into this :)
bq. I would make a point that config.yml is actually the lowres as I saw people
being confused about that.
Good idea. I have changed the script messages and the readme trying to make it
clear that the default {{config.yml}} uses low resources and that it is indeed
a copy of {{confilg.yml.LOWRES}}. I have included a very brief [introductory
section|https://github.com/adelapena/cassandra/blob/16871-3.0/.circleci/readme.md#circleci-config-files]
in the readme in an attempt to give some context.
bq. One thing, if you are using higher resources and later in time you decide
also to change any of the environment variables, we should make it clear that
running only .circleci/generate.sh will return people to default low resources
with the new variables. If they want to keep the new resources they should use
a flag again. Someone new might get confused.
Makes sense, I have added an explicit warning about this
[here|https://github.com/apache/cassandra/commit/4852b080a773493cb2e6d0bcb53931a703a2ebfa].
> Add resource flags to CircleCi config generation script
> -------------------------------------------------------
>
> Key: CASSANDRA-16871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16871
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Low
>
> Currently we have three versions of the CircleCI config file using different
> resources. Changing the resources configuration is as easy as copying the
> desired template file, for example:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> {code}
> If we want to make changes to the file, for example to set a specific dtest
> repo or running the test multiplexer, we can run the provided generation
> script, copy the template file and probably exclude the additional changes:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # undo the changes in config.yml.LOWRES, config.yml.MIDRES and
> config.yml.HIGHRES
> {code}
> A very common alternative to this is just editing the environment variables
> in the automatically generated {{config.yml}} file, which are repeated some
> 19 times across the file:
> {code}
> cp .circleci/config.yml.MIDRES .circleci/config.yml
> # edit config.yml, where env vars are repeated
> {code}
> I think we could do this slightly easier by adding a set of flags to the
> generation script to apply the resources patch directly to {{config.yml}},
> without changing the templates:
> {code}
> # edit config-2_1.yml
> .circleci/generate.sh -m
> {code}
> This has the advantage of not requiring manually editing the automatically
> generated file and also providing some validation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
