[
https://issues.apache.org/jira/browse/CASSANDRA-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421239#comment-17421239
]
Berenguer Blasi commented on CASSANDRA-16996:
---------------------------------------------
Pre CI run is done now
[j11|https://app.circleci.com/pipelines/github/bereng/cassandra/438/workflows/edcb3e2e-a6f1-416b-8587-a6e82c387cb1]
and
[j8|https://app.circleci.com/pipelines/github/bereng/cassandra/438/workflows/4f56dcf3-e467-445e-a34c-cfce0b196ae2]
which I was worried about.
1.) Yes these are some of the holes. But other 'multi-step' methods such as
{{fetchKeyspace}} i.e. are not atomic. We could have changes get in-between
each method it calls iiuc etc.
2.) Yes adding a javadoc along a note on each method as Josh mentioned is a
good idea.
3.) The fuzz test I really dislike here an I am not entirely sure why.
Overloading the class and making sure the syncs work would be my preference,
short of that the junit we have now does the trick imo. At the end of the day
is making sure the contract (API) won't be broken by accident in a
deterministic way.
> Prevent broken concurrent schema read/writes
> --------------------------------------------
>
> Key: CASSANDRA-16996
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16996
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 3.11.x, 4.0, 4.x
>
>
> See CASSANDRA-16856 where the concurrent read/write path was left out
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
