[ 
https://issues.apache.org/jira/browse/CASSANDRA-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421338#comment-17421338
 ] 

Benedict Elliott Smith commented on CASSANDRA-16996:
----------------------------------------------------

Tests should verify that the behaviour we care about is correct, not that some 
specific artefact of the implementation is maintained.

I haven't looked carefully at this patch, but if we are to solve this using 
{{synchronized}} we should consider that currently the {{Schema}} class 
controls mutually exclusivity on {{applyChanges}} and perhaps this class should 
be the public API for these other two API methods. It seems these are the 
_only_ two public methods in {{SchemaKeyspace}} and so it would be easy to 
migrate public accessors to {{Schema}}, and perhaps even make 
{{SchemaKeyspace}} package private by migrating its public fields as well.

> Prevent broken concurrent schema read/writes
> --------------------------------------------
>
>                 Key: CASSANDRA-16996
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16996
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Cluster/Schema
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 3.11.x, 4.0, 4.x
>
>
> See CASSANDRA-16856 where the concurrent read/write path was left out



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to