[ 
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429871#comment-17429871
 ] 

Berenguer Blasi commented on CASSANDRA-16956:
---------------------------------------------

Given the big PR it would be nice to have up-to-date CI results before a final 
review imo. But so far I would suggest:
- Remove {{WindowsFailedSnapshotTracker}}
-  Remove references to windows on : SSTableExport.java, conf/cqlshrc.sample 
and doc/source/troubleshooting/index.rst.
- Is the comment on Windows in test/conf/cdc.yaml an opportunity to simplify 
cdc config?

> Remove windows-specific classes
> -------------------------------
>
>                 Key: CASSANDRA-16956
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Brandon Williams
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no 
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to