[ https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430129#comment-17430129 ]
Stefan Miklosovic commented on CASSANDRA-16956: ----------------------------------------------- hi [~Bowen Song], would you mind to take a look at this test specifically? cqlshlib.python3.jdk8.no_cython.test.test_cqlsh_output.TestCqlshOutput.test_exit_prints_no_newline In cassandra repo, they are in pylib/cqlshlib/test/test_cql_output.py That test tests that if exit is used in the shell, it will not print new line, I think it has something to do with the changes you did. Or maybe the test just needs to be modified? You execute these tests as "cd pylib && ./cassandra-cqlsh-tests.sh ../" https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1214/#showFailuresLink > Remove windows-specific classes > ------------------------------- > > Key: CASSANDRA-16956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16956 > Project: Cassandra > Issue Type: Task > Components: Build > Reporter: Brandon Williams > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 4.0.x, 4.x > > > To continue the work CASSANDRA-16171 began, now that Windows support is no > more there are some source files that can be removed. > Just doing a naive grep on the source directory I see: > {noformat} > src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java > src/java/org/apache/cassandra/utils/NativeLibraryWindows.java > src/java/org/apache/cassandra/utils/WindowsTimer.java > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org