[ 
https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431258#comment-17431258
 ] 

Benedict Elliott Smith edited comment on CASSANDRA-17044 at 10/20/21, 2:02 PM:
-------------------------------------------------------------------------------

bq. HintsManager

This is a {{HintsService}}, or perhaps a {{HintsStore}}

Additionally, we have {{CommitLog}}, {{SystemKeyspace}}, 
{{SystemDistributedKeyspace}}, {{Tracing}}, {{PaxosState}}, 
{{CassandraMetricsRegistry}}, {{MessagingService}}, {{ActiveRepairService}}, 
{{VirtualKeyspaceRegistry}}, {{FullQueryLogger}}, {{DiagnosticEventService}}, 
{{PendingRangeCalculatorService}}, {{CacheService}}, and no doubt many more.

There are many {{XManager}} objects as well, but as far as I can tell these are 
all countable nouns as I previously posited. {{Schema}} is not a countable 
noun, and there is no specific set of {{Schema}} object to be managed, so 
consistency is not a valid justification for this refactor in my view. Brevity 
remains important.


was (Author: benedict):
bq. HintsManager

This is a {{HintsService}, or perhaps a {{HintsStore}}

Additionally, we have {{CommitLog}}, {{SystemKeyspace}}, 
{{SystemDistributedKeyspace}}, {{Tracing}}, {{PaxosState}}, 
{{CassandraMetricsRegistry}}, {{MessagingService}}, {{ActiveRepairService}}, 
{{VirtualKeyspaceRegistry}}, {{FullQueryLogger}}, {{DiagnosticEventService}}, 
{{PendingRangeCalculatorService}}, {{CacheService}}, and no doubt many more.

There are many {{XManager}} objects as well, but as far as I can tell these are 
all countable nouns as I previously posited. {{Schema}} is not a countable 
noun, and there is no specific set of {{Schema}} object to be managed, so 
consistency is not a valid justification for this refactor in my view. Brevity 
remains important.

> Refactor schema management to allow for schema source pluggability
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-17044
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17044
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Cluster/Schema
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>
> The idea is decompose `Schema` into separate entities responsible for 
> different things. In particular extract what is related to schema storage and 
> synchronization into a separate class so that it is possible to create an 
> extension point there and store schema in a different way than 
> `system_schema` keyspace, for example in etcd. 
> This would also simplify the logic and reduce the number of special cases, 
> make all the things more testable and the logic of internal classes 
> encapsulated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to