[
https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431259#comment-17431259
]
Alex Petrov edited comment on CASSANDRA-17044 at 10/20/21, 2:06 PM:
--------------------------------------------------------------------
[~jlewandowski] could you give some background on how you're planning to use /
plug in etcd? Some changes are just not fully obvious without this information.
I really like strides towards encapsulation, just want to understand where some
of the things coming from.
[~paulo] just to make sure, there's no explicit entity that is called
{{Schema}} unlike all other examples. There's no {{HintsManager}}, but it's
likely that you mean {{HintsStore}}, but there are also {{Hint}} s. Similarly,
there are {{CompactionStrateg}} ies and there is their manager. I do not see
how this makes the codebase more consistent (if only because we use the word
{{Manager}} more), or more meaningful. I'm sure there never was any confusion
about what {{Schema}} class represents. I agree with what Benedict has
mentioned above with regard the fact that {{XManager}} is well used with
countable nouns, where it makes it clear that it manager multiple instances of
{{X}}.
was (Author: ifesdjeen):
[~jlewandowski] could you give some background on how you're planning to use /
plug in etcd? Some changes are just not fully obvious without this information.
I really like strides towards encapsulation, just want to understand where some
of the things coming from.
[~paulo] just to make sure, there's no explicit entity that is called
{{Schema}} unlike all other examples. There's no {{HintsManager}}, but it's
likely that you mean {{HintsDispatcher}}, but there are also {{Hint}} s.
Similarly, there are {{CompactionStrateg}} ies and there is their manager. I do
not see how this makes the codebase more consistent (if only because we use the
word {{Manager}} more), or more meaningful. I'm sure there never was any
confusion about what {{Schema}} class represents. I agree with what Benedict
has mentioned above with regard the fact that {{XManager}} is well used with
countable nouns, where it makes it clear that it manager multiple instances of
{{X}}.
> Refactor schema management to allow for schema source pluggability
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17044
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17044
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
>
> The idea is decompose `Schema` into separate entities responsible for
> different things. In particular extract what is related to schema storage and
> synchronization into a separate class so that it is possible to create an
> extension point there and store schema in a different way than
> `system_schema` keyspace, for example in etcd.
> This would also simplify the logic and reduce the number of special cases,
> make all the things more testable and the logic of internal classes
> encapsulated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
