[
https://issues.apache.org/jira/browse/CASSANDRA-17180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452986#comment-17452986
]
Paulo Motta edited comment on CASSANDRA-17180 at 12/3/21, 1:19 PM:
-------------------------------------------------------------------
Had an initial glance at the patch and it is looking good. I'd probably rename
the properties to reflect the actual end-user feature being added since
heartbeat is an implementation detail of the startup check, so we can even
replace the implementation later on while keeping the startup check without
affecting user experience.
Here are some suggestions to the property name to better reflect the feature
(suggestions welcome):
* verify_gc_grace_seconds_on_startup
* enable_startup_consistency_check
* check_consistency_on_startup
* check_gc_grace_seconds_on_startup
Also, can we add a way to opt-in/opt-out some tables from the check? Because
some append-only TTLed tables it's common to use a low gc grace seconds so
operators would probably want to exclude these tables from the check.
was (Author: paulo):
Had an initial glance at the patch and it is looking good. I'd probably rename
the properties to reflect the actual end-user feature being added since
heartbeat is an implementation detail of the startup check, so we can even
replace the implementation later on while keeping the startup check without
affecting user experience.
Here are some suggestions to the property name to better reflect the feature
(suggestions welcome):
* verify_gc_grace_seconds_on_startup
* enable_startup_consistency_check
* check_consistency_on_startup
* check_gc_grace_seconds_on_startup
Also, can we add a way to opt-in/opt-out some tables from the check? Because
some append-only TTLed tables it's common to use a low gc grace seconds so
operators would probably want to exclude these tables from the check.
> Implement heartbeat service to know last time Cassandra node was up
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17180
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As already discussed on ML, it would be nice to have a service which would
> periodically write timestamp to a file signalling it is up / running.
> Then, on the startup, we would read this file and we would determine if there
> is some table which gc grace is behind this time and we would fail the start
> so we would prevent zombie data to be likely spread around a cluster.
> https://lists.apache.org/thread/w4w5t2hlcrvqhgdwww61hgg58qz13glw
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
