[
https://issues.apache.org/jira/browse/CASSANDRA-17180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453057#comment-17453057
]
Stefan Miklosovic edited comment on CASSANDRA-17180 at 12/3/21, 2:50 PM:
-------------------------------------------------------------------------
Well if we want to do that, then the whole patch as is now is just useless,
more or less. I think we would need to hook it here (1) with a lot of plumbing
around.
Anyway, in more general terms, do we trully need the heartbeat functionality
just for the resolution of gc grace period? Is not there any other usecase or
utility from keeping this check outside of commit log syncing? Are we sure we
want to couple heartbeats with that?
Other problem I see is that - not sure about the internals, but I guess syncing
can happen way more often that each minute, do we want to "polute" the syncing
logic with some seemingly irelevant heartbeats stuff? There are various
implementations of CommitLogService - Batch, Group, Periodic with different
semantics etc.
(1)
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/AbstractCommitLogService.java#L189]
was (Author: smiklosovic):
Well if we want to do that, then the whole patch as is now is just useless,
more or less. I think we would need to hook it here (1) with a lot of plumbing
around.
Anyway, in more general terms, do we trully need the heartbeat functionality
just for the resolution of gc grace period? Is not there any other usecase or
utility from keeping this check outside of commit log syncing? Are we sure we
want to couple heartbeats with that?
(1)
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/AbstractCommitLogService.java#L189]
> Implement heartbeat service to know last time Cassandra node was up
> -------------------------------------------------------------------
>
> Key: CASSANDRA-17180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17180
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Observability
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As already discussed on ML, it would be nice to have a service which would
> periodically write timestamp to a file signalling it is up / running.
> Then, on the startup, we would read this file and we would determine if there
> is some table which gc grace is behind this time and we would fail the start
> so we would prevent zombie data to be likely spread around a cluster.
> https://lists.apache.org/thread/w4w5t2hlcrvqhgdwww61hgg58qz13glw
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
