[
https://issues.apache.org/jira/browse/CASSANDRA-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17189:
---------------------------------------
Description:
Add guardrail limiting the query page size, for example:
{code}
# Guardrail to warn about or reject page sizes greater than threshold.
# The two thresholds default to -1 to disable.
page_size:
warn_threshold: -1
abort_threshold: -1
{code}
Initially this can be based on the specified number of rows used as page size,
although it would be ideal to also limit the actual size in bytes of the
returned pages.
+Additional information for newcomers:+
# Add the configuration for the new guardrail on page size in the guardrails
section of cassandra.yaml.
# Add a getPageSize method in GuardrailsConfig returning a Threshold.Config
object
# Implement that method in GuardrailsOptions, which is the default yaml-based
implementation of GuardrailsConfig
# Add a Threshold guardrail named pageSize in Guardrails, using the previously
created config
# Define JMX-friendly getters and setters for the previously created config in
GuardrailsMBean
# Implement the JMX-friendly getters and setters in Guardrails
# Now that we have the guardrail ready, it’s time to use it. We should search
for a place to invoke the Guardrails.pageSize#guard method with the page size
that each query is going to use. The DataLimits#forPaging methods look like
good candidates for this.
# Finally, add some tests for the new guardrail. Given that the new guardrail
is a Threshold, our new test should probably extend ThresholdTester.
was:
Add guardrail limiting the query page size, for example:
{code}
# Guardrail to warn about or reject page sizes greater than threshold.
# The two thresholds default to -1 to disable.
page_size:
warn_threshold: -1
abort_threshold: -1
{code}
Initially this can be based on the specified number of rows used as page size,
although it would be ideal to also limit the actual size in bytes of the
returned pages.
> Guardrail for page size
> -----------------------
>
> Key: CASSANDRA-17189
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17189
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 4.1
>
>
> Add guardrail limiting the query page size, for example:
> {code}
> # Guardrail to warn about or reject page sizes greater than threshold.
> # The two thresholds default to -1 to disable.
> page_size:
> warn_threshold: -1
> abort_threshold: -1
> {code}
> Initially this can be based on the specified number of rows used as page
> size, although it would be ideal to also limit the actual size in bytes of
> the returned pages.
> +Additional information for newcomers:+
> # Add the configuration for the new guardrail on page size in the guardrails
> section of cassandra.yaml.
> # Add a getPageSize method in GuardrailsConfig returning a Threshold.Config
> object
> # Implement that method in GuardrailsOptions, which is the default yaml-based
> implementation of GuardrailsConfig
> # Add a Threshold guardrail named pageSize in Guardrails, using the
> previously created config
> # Define JMX-friendly getters and setters for the previously created config
> in GuardrailsMBean
> # Implement the JMX-friendly getters and setters in Guardrails
> # Now that we have the guardrail ready, it’s time to use it. We should search
> for a place to invoke the Guardrails.pageSize#guard method with the page size
> that each query is going to use. The DataLimits#forPaging methods look like
> good candidates for this.
> # Finally, add some tests for the new guardrail. Given that the new guardrail
> is a Threshold, our new test should probably extend ThresholdTester.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
