[
https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460963#comment-17460963
]
Benjamin Lerer edited comment on CASSANDRA-16378 at 12/16/21, 6:44 PM:
-----------------------------------------------------------------------
{quote}
As a reasonable alternative, we could capture all options from STARTUP MESSAGE
into a hash and output that via the clients virtual table as a collection. That
could be more versatile but add more complexity. That would also need to
clarify of transporting all options or just those not consumed otherwise.
{quote}
I like that approach.
Regarding your question about testing, I looked into it and unfortunately the
driver version used withing the C* code base do not support that option.
Upgrading might be a bit complicated so I am fine with testing it manually for
now.
was (Author: blerer):
{quote}As a reasonable alternative, we could capture all options from STARTUP
MESSAGE into a hash and output that via the clients virtual table as a
collection. That could be more versatile but add more complexity. That would
also need to clarify of transporting all options or just those not consumed
otherwise.
{quote}
I like that approach.
Regarding your question about testing, I looked into it and unfortunately the
driver version used withing the C* code base do not support that option.
Upgrading might be a bit complicated so I am fine with testing it manually for
now.
> Expose application_name and application_version in virtual table
> system_views.clients
> -------------------------------------------------------------------------------------
>
> Key: CASSANDRA-16378
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16378
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
> Reporter: Tibor Repasi
> Assignee: Tibor Repasi
> Priority: Normal
> Labels: AdventCalendar2021, gsoc2021, lhf, mentor
>
> Recent java-driver's
> [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html]
> respects properties
> [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-]
> and
> [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-].
> It would be helpful to exposed this information via virtual table
> {{system_views.clients}} and with {{nodetool clientstats}}.
> +Additional information for newcomers:+
> The drivers can send as part of the {{STARTUP MESSAGE}} the
> {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. To new volatile
> fields {{applicationName}} and {{applicationVersion}} need to be added to
> {{ClientState}} in a similar way to {{driverName}} and {{driverVersion}}.
> The {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} optionsneed to be
> retrieved in {{StartupMessage#execute}} and passed to the {{ClientState}}.
> The new {{application_name}} and {{application_version}} columns need to be
> added to the {{system_views.clients}} represented by the {{ClientsTable}}
> class. The data then need to be retrieved from the {{ClientState}} through
> {{ConnectedClient}}.
> Some unit tests similat to {{SettingsTableTest}} should be added.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
