[ 
https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463328#comment-17463328
 ] 

Tibor Repasi edited comment on CASSANDRA-16378 at 12/21/21, 4:16 PM:
---------------------------------------------------------------------

Solved the above. My remaining question on that is, what is MultiCell and why 
is it needed to be false?

Have updated the PR. Now, you can query the following:
{code}
superuser@cqlsh> SELECT address, port, client_options FROM system_views.clients;

 address   | port  | client_options
-----------+-------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 127.0.0.1 | 49172 | {'APPLICATION_NAME': 'TestApp', 'APPLICATION_VERSION': 
'1.2.3', 'CLIENT_ID': '79572fc6-8a05-419d-b53a-073d03d601e7', 'CQL_VERSION': 
'3.0.0', 'DRIVER_NAME': 'DataStax Java driver for Apache Cassandra(R)', 
'DRIVER_VERSION': '4.13.0'}
 127.0.0.1 | 49173 | {'APPLICATION_NAME': 'TestApp', 'APPLICATION_VERSION': 
'1.2.3', 'CLIENT_ID': '79572fc6-8a05-419d-b53a-073d03d601e7', 'CQL_VERSION': 
'3.0.0', 'DRIVER_NAME': 'DataStax Java driver for Apache Cassandra(R)', 
'DRIVER_VERSION': '4.13.0'}
 127.0.0.1 | 64951 |                                                            
                                                                               
{'CQL_VERSION': '3.4.5', 'DRIVER_NAME': 'DataStax Python Driver', 
'DRIVER_VERSION': '3.25.0'}
 127.0.0.1 | 64953 |                                                            
                                                                               
{'CQL_VERSION': '3.4.5', 'DRIVER_NAME': 'DataStax Python Driver', 
'DRIVER_VERSION': '3.25.0'}

(4 rows)
{code}



was (Author: rtib):
Solved the above. My remaining question on that is, what is MultiCell and why 
is it needed to be false?

Have updated the PR. Now, you can query the following:
{code}
superuser@cqlsh> SELECT address, port, client_options FROM system_views.clients;

 address   | port  | client_options
-----------+-------+-----------------------------------------------------------------------------------------------
 127.0.0.1 | 64951 | {'CQL_VERSION': '3.4.5', 'DRIVER_NAME': 'DataStax Python 
Driver', 'DRIVER_VERSION': '3.25.0'}
 127.0.0.1 | 64953 | {'CQL_VERSION': '3.4.5', 'DRIVER_NAME': 'DataStax Python 
Driver', 'DRIVER_VERSION': '3.25.0'}

(2 rows)
{code}


> Expose application_name and application_version in virtual table 
> system_views.clients
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16378
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16378
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Tibor Repasi
>            Assignee: Tibor Repasi
>            Priority: Normal
>              Labels: AdventCalendar2021, gsoc2021, lhf, mentor
>
> Recent java-driver's 
> [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html]
>  respects properties 
> [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-]
>  and 
> [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-].
> It would be helpful to exposed this information via virtual table 
> {{system_views.clients}} and with {{nodetool clientstats}}.
> +Additional information for newcomers:+
> The drivers can send as part of the {{STARTUP MESSAGE}} the 
> {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. To new volatile 
> fields {{applicationName}} and {{applicationVersion}} need to be added to 
> {{ClientState}} in a similar way to {{driverName}} and {{driverVersion}}.
> The  {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} optionsneed to be 
> retrieved in {{StartupMessage#execute}} and passed to the {{ClientState}}. 
> The new {{application_name}} and {{application_version}} columns need to be 
> added to the {{system_views.clients}} represented by the {{ClientsTable}} 
> class. The data then need to be retrieved from the {{ClientState}} through 
> {{ConnectedClient}}.
> Some unit tests similat to {{SettingsTableTest}} should be added. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to