[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472201#comment-17472201
]
Brandon Williams edited comment on CASSANDRA-16956 at 1/10/22, 6:16 PM:
------------------------------------------------------------------------
bq. Removal of code is not zero-risk, and this is 4.0 GA branch. Much like we
don't do small improvements on non-trunk branches, my understanding is the same
logic means we also don't do code removal / cruft cleanup / other refactors on
non-trunk as well.
I definitely agree with all of that. However, this is platform-specific code,
and it could be argued that not removing it when Windows support was deprecated
is a bug; after all CASSANDRA-16171 took a first pass. Significantly though,
the genesis of this ticket was the implications of this cruft on security in
CASSANDRA-14612.
It looks like after the holiday break there's been some branch->CI disconnect.
I've started runs against these branches, which I think is accurate, but please
correct me otherwise:
||branch||CI||
|[4.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-16956-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1358/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1358/pipeline]|
|[trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-16956-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1359/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1359/pipeline]|
was (Author: brandon.williams):
bq. Removal of code is not zero-risk, and this is 4.0 GA branch. Much like we
don't do small improvements on non-trunk branches, my understanding is the same
logic means we also don't do code removal / cruft cleanup / other refactors on
non-trunk as well.
I definitely agree with all of that. However, this is platform-specific code,
and it could be argued that not removing it when Windows support was deprecated
is a bug; after all CASSANDRA-16171 took a first pass. Significantly though,
the genesis of this ticket was the implications of this cruft on security in
CASSANDRA-14612.
It looks like after the holiday break there's been some branch->CI disconnect.
I've started runs against these branches, which I think is accurate, but please
correct me otherwise:
||branch||CI||
|[4.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-16956-4.0]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1358/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1358/pipeline]|
[trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-16956-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1359/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1359/pipeline]|
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
