[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472548#comment-17472548
]
Berenguer Blasi edited comment on CASSANDRA-16956 at 1/11/22, 8:28 AM:
-----------------------------------------------------------------------
Thx [~brandon.williams]!
Just for the record I would also prefer not to touch 4.0 for the reasons
[~jmckenzie] mentions about being a non-zero risk activity. But I'll defer to
the author's preference and we're on a tie anyway iiuc.
- 4.0 lgtm. The only minor left-overs are in LogbackStatusListener, some sample
config file with a Win path and some code comments. I think we can live with
those.
- trunk lgtm. Same.
- We're missing creating 1 ticket for the docs work and another one for the
dtests work.
- I would also like to ping [~mck] for a cursory sanity check. I just have that
nagging feeling some rpm or other release build job might break.
+1
was (Author: bereng):
Thx [~brandon.williams]!
Just for the record I would also prefer not to touch 4.0 for the reasons
[~jmckenzie] mentions about being a non-zero risk activity. But I'll defer to
the author's preference and we're on a tie anyway iiuc.
- 4.0 lgtm. The only minor left-overs are in LogbackStatusListener, some sample
config file with a Win path and some code comments. I think we can live with
those.
- trunk lgtm. Same.
- We're missing creating 1 ticket for the docs work and another one for the
dtests work.
+1
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc, signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
