[ 
https://issues.apache.org/jira/browse/CASSANDRA-17430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505047#comment-17505047
 ] 

Andres de la Peña commented on CASSANDRA-17430:
-----------------------------------------------

The above patch uses the prefixes proposed in the description, we could also go 
for suffixes mentioning the config properties such as:
 * {{Query for table %s with page size %s exceeds warning threshold of %s. This 
is set by the config property "page_size_warn_threshold" in cassandra.yaml}}
 * {{Aborting query for table %s, page size %s exceeds fail threshold of %s. 
This is set by the config property "page_size_abort_threshold" in 
cassandra.yaml}}
 * {{List operation requiring read before write is not allowed. This is set by 
the config property "read_before_write_list_operations_enabled" in 
cassandra.yaml}}
 

> Improve guardrails messages
> ---------------------------
>
>                 Key: CASSANDRA-17430
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17430
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Guardrails
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 4.x
>
>
> As it has been mentioned by [~JoshuaMcKenzie] , current guardrail messages 
> don't mention that the warning or failure is due to the triggering of a 
> specific guardrail. For example, some error messages are:
> * {{Query for table %s with page size %s exceeds warning threshold of %s.}}
> * {{Aborting query for table %s, page size %s exceeds fail threshold of %s.}}
> * {{List operation requiring read before write is not allowed}}
> This ticket aims to improve that behaviour so the messages contain a specific 
> mention of guardrails, for example prepending a common prefix to the messages:
> * {{Guardrail page_size violated: Query for table %s with page size %s 
> exceeds warning threshold of %s.}}
> * {{Guardrail page_size violated: Aborting query for table %s, page size %s 
> exceeds fail threshold of %s.}}
> * {{Guardrail read_before_write_list_operations violated: List operation 
> requiring read before write is not allowed}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to