[
https://issues.apache.org/jira/browse/CASSANDRA-17430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507159#comment-17507159
]
Josh McKenzie commented on CASSANDRA-17430:
-------------------------------------------
We had a delta in our JenkinsFile excluding all dtest failures from butler and
jenkins for a bit. That's resolved now, but the test board on trunk is looking
rough.
Doubt this patch had anything to do with the 25 failures below.
[CI Results]
Branch: trunk, build number: 1008
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-trunk/1008/]
JIRA: CASSANDRA-17430
commit url:
[https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=0ecd48001fab88d2d53c717ef47cd3bc0d1369d0]
affected paths:
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailsConfigProviderTest.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailViewsPerTableTest.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailPageSizeTest.java
* src/java/org/apache/cassandra/db/guardrails/Guardrail.java
* src/java/org/apache/cassandra/db/guardrails/Values.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailReadConsistencyLevelsTest.java
* src/java/org/apache/cassandra/db/guardrails/Guardrails.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailConsistencyLevelsTester.java
* src/java/org/apache/cassandra/db/guardrails/DisableFlag.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailReadBeforeWriteListOperationsTest.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailUserTimestampsTest.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailWriteConsistencyLevelsTest.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailPartitionKeysInSelectTest.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailKeyspacesTest.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailInSelectCartesianProductTest.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailTablesTest.java
* src/java/org/apache/cassandra/db/guardrails/Threshold.java
* CHANGES.txt
* test/unit/org/apache/cassandra/db/guardrails/GuardrailsTest.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailColumnsPerTableTest.java
* test/unit/org/apache/cassandra/db/guardrails/ThresholdTester.java
* src/java/org/apache/cassandra/db/guardrails/GuardrailViolatedException.java
*
test/unit/org/apache/cassandra/db/guardrails/GuardrailSecondaryIndexesPerTable.java
* test/unit/org/apache/cassandra/db/guardrails/GuardrailTester.java
Build Result: UNSTABLE
Passing Tests: 44474
Failing Tests: 25
||Test|Failures|JIRA|
|org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition|3
of 60|CASSANDRA-17244?|
|org.apache.cassandra.cql3.KeywordTest.test[keyword ACCESS isReserved false]|3
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.PreparedStatementsTest.testInvalidatePreparedStatementsOnDrop-compression|1
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-novnode.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|6
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.cql_tests.cls.test_noncomposite_static_cf|2 of
60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade|26
of 60|CASSANDRA-17305?|
|org.apache.cassandra.distributed.test.CasCriticalSectionTest.criticalSectionTest|6
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.net.proxy.ProxyHandlerTest.testNormalDelivery|2 of 60|[No
JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.KeywordTest.test[keyword INT isReserved false]|1 of
60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade|26
of 60|CASSANDRA-17305?|
|org.apache.cassandra.cql3.validation.operations.CompactStorageTest.testIndicesOnCompactTable|3
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.KeywordTest.test[keyword DOUBLE isReserved false]|1
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.KeywordTest.test[keyword ALLOW isReserved true]|2 of
60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_indev_4_0_x_To_indev_trunk.test_static_cf|3
of 60|CASSANDRA-17309?|
|org.apache.cassandra.db.commitlog.BatchCommitLogTest.replaySimple[3]-cdc|1 of
60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade_with_internode_ssl|25
of 60|CASSANDRA-17305?|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade_with_internode_ssl|25
of 60|CASSANDRA-17305?|
|org.apache.cassandra.distributed.test.CASTest.testSuccessfulWriteDuringRangeMovementFollowedByConflicting|3
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|6
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.db.SinglePartitionSliceCommandTest.testPartitionDeletionRangeDeletionTie|1
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-offheap.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|6
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.KeywordTest.test[keyword DURATION isReserved
false]|2 of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_current_4_0_x_To_indev_trunk.test_static_cf|2
of 60|CASSANDRA-17309?|
|org.apache.cassandra.cql3.KeywordTest.test[keyword FROZEN isReserved false]|1
of 60|[No JIRA
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
> Improve guardrails messages
> ---------------------------
>
> Key: CASSANDRA-17430
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17430
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As it has been mentioned by [~JoshuaMcKenzie] , current guardrail messages
> don't mention that the warning or failure is due to the triggering of a
> specific guardrail. For example, some error messages are:
> * {{Query for table %s with page size %s exceeds warning threshold of %s.}}
> * {{Aborting query for table %s, page size %s exceeds fail threshold of %s.}}
> * {{List operation requiring read before write is not allowed}}
> This ticket aims to improve that behaviour so the messages contain a specific
> mention of guardrails, for example prepending a common prefix to the messages:
> * {{Guardrail page_size violated: Query for table %s with page size %s
> exceeds warning threshold of %s.}}
> * {{Guardrail page_size violated: Aborting query for table %s, page size %s
> exceeds fail threshold of %s.}}
> * {{Guardrail read_before_write_list_operations violated: List operation
> requiring read before write is not allowed}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
