[
https://issues.apache.org/jira/browse/CASSANDRA-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519800#comment-17519800
]
Ekaterina Dimitrova commented on CASSANDRA-17431:
-------------------------------------------------
Rebased and squashed in this new
[branch|https://github.com/apache/cassandra/commit/6a8851180b10546036b0771b21ec701096b2baf0](left
the old one for reference around the review discussions, will update
CHANGES.txt, commit message, authorship, etc at the end), following changes for
your consideration done:
* I didn't add an entry that we got rid of the option to set 0 without unit
for Duration and DataStorage as it wasn't advertised before but leaving here
for the record. This led to change in MILLIS_DOUBLE_DURATION to handle NaN
which was a valid value for commitlog_sync_group_window_in_ms
* As part of the patch we took care of a bug with permissions_update_interval,
credentials_update_interval, roles_update_interval - former -1 should point to
null and not 0 which was and it is a valid value. Also, their setter in
DatabaseDescriptors match the startup behavior and throw
IllegalArgumentException, instead of ConfigurationException from DurationSpec.
* setNativeTransportReceiveQueueCapacityInBytes - called only by tests, so I
didn't do anything about Configuration exception
* I added to the Setters for roles_update_interval,
credentials_update_interval, permissions_update_interval
IllegalArgumentEception instead of ConfigurationException until
* native_transport_max_request_data_in_flight_per_ip - changed to default in
case of -1, rejects anything less than -1. Considered as bug. Communicated on
the mailing list. Added comment in Config. Is JavaDoc better? Exception will be
thrown as IllegalArgumentException, the setter is called by
ClientResourceLimits#setEndpointLimit, called by
StorageService#setNativeTransportMaxConcurrentRequestsInBytesPerIp. Reflected
the change also in BYTES_CUSTOM_DATASTORAGE Converter
* The setters setUserDefinedFunctionFailTimeout and
setUserDefinedFunctionWarnTimeout are called only by test functions so I didn't
take care explicitly of the ConfigurationException.
* validation_preview_purge_head_start - the Converter created for it
NEGATIVE_SECONDS_DURATION sets to 0 anything negative as the only usage of this
parameter is in getValidationPreviewPurgeHeadStartInSec where up to now we were
doing
{code:java}
int seconds = conf.validation_preview_purge_head_start_in_sec; return
Math.max(seconds, 0);{code}
* Commit from David to make Converters type safe and fixed a few cases where
converters used the wrong type
* Tests for all branches of all Converters for the convert part added. I guess
for the deconvert part for the Virtual Table we have the methods tested and
they don't have branches, except MILLIS_CUSTOM_DURATION. I added also
testSetConfigDisabled().
CCM commits squashed, typo fixed, new tag
[cassandra-test-17431|https://github.com/ekaterinadimitrova2/ccm/tags] created
in my branch for testing.
[J8
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1508/workflows/37edd685-8049-4af7-8099-b47a67aab7c0]all
test failures are known and have tickets. I will push J11 on final
confirmation.
[Upgrade
tests|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1508/workflows/bb62e69c-0dc0-4e55-b847-f2b405f87646/jobs/9815/tests]
restarted and finished as expected. It seems there was git issue that
[~dcapwell] hit also with another ticket and the original ccm.
> Move the rest of the Config parameters to the new Config framework
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17431
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17431
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> Migrate also all Config parameters that are in Config, but not presented in
> cassandra.yaml to the new config framework. Not presented in the yaml as they
> are considered advanced only for advanced users.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
