[
https://issues.apache.org/jira/browse/CASSANDRA-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537881#comment-17537881
]
Ekaterina Dimitrova commented on CASSANDRA-17571:
-------------------------------------------------
Thanks, I just addressed the review comments and [ran
CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=review&filter=all]
on 4.1. 2 known failures and 2 unit tests that I have missed to update. Added
to the PR a fix now.
A few things to mention here:
* I also updated the docs plus added min unit in cassandra.yaml for the
properties where it made sense. What I mean - if a property default value is in
B in the yaml, it is obvious we can set all units, so it didn't make sense to
me to pollute the yaml for those properties.
* Worth to mention here that now all three main classes (DataRateSpec,
DurationSpec, DataStorageSpec) are abstract and people should use the extended
classes which are now tested. I added a test to validate Config types, that
people didn't use as type abstract class with constructor of a nested class.
This will compile fine and if no value is set in cassandra.yaml, everything
will be fine, BUT if someone adds a value in the yaml - then Cassandra won't
start because SnakeYAML will want to use abstract class constructor. [The
test|https://github.com/ekaterinadimitrova2/cassandra/pull/199/files#diff-392bbe6df967db1b9b2c70cb97bbd84779fa847b11573ed11ca601578ebf2936R48-R59]
I added checks that no parameter has as a type any of the three abstract
classes to prevent us from future bugs. In that sense, paxos_purge_grace_period
is fixed now as the author has done the mistake I mentioned originally. (using
the main class and because the main classes were not abstract this was even
worse as de facto the smallest Duration unit was set to nanoseconds).
> Config upper bound should be handled earlier
> --------------------------------------------
>
> Key: CASSANDRA-17571
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17571
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> Config upper bound should be handled on startup/config setup and not during
> conversion
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
