[
https://issues.apache.org/jira/browse/CASSANDRA-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540196#comment-17540196
]
Ekaterina Dimitrova commented on CASSANDRA-17571:
-------------------------------------------------
Rebased
[here|https://github.com/ekaterinadimitrova2/cassandra/pull/new/17571-final]
in a new branch to preserve the unsquashed version for reference.
(there were unfortunately merge conflicts after the exception handling patch
committed yesterday but I think things are fine, at least unit tests
Guardrails, setGet* and config are passing locally). The move of the static
conversion methods led to IntKibibytesBoundToBytes which led to the need of
change in the DatabaseDescriptor
[here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:17571-final?expand=1#diff-054af65b8d690b0fddc3e0a4ef05a80d8f1d6689b4f77912795fec019200666cR551]
and
[here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:17571-final?expand=1#diff-054af65b8d690b0fddc3e0a4ef05a80d8f1d6689b4f77912795fec019200666cR3706]
which should be fine as Integer.MAX_VALUE cannot be divided by 1024 to an
integer so we don't need it.
I also removed one of the non-negative validations in the constructor which
doesn't need it because that is ensured already by the pattern matching. I
added a test for that too
[here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:17571-final?expand=1#diff-b02560e1a47ddce2e07855a3aaf2931b1987e17d75ff99d01d44fedcaf2d83b1R87]
CI running
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17571-final&filter=all]
trunk comes in 10 minutes I hope as I don't expect the cherry-picked commit to
have many conflicts there.
> Config upper bound should be handled earlier
> --------------------------------------------
>
> Key: CASSANDRA-17571
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17571
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> Config upper bound should be handled on startup/config setup and not during
> conversion
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
