[
https://issues.apache.org/jira/browse/CASSANDRA-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540644#comment-17540644
]
Paulo Motta commented on CASSANDRA-17619:
-----------------------------------------
Nice catch - it seems this also failed on ASF CI
([PreviewRepairCoordinatorNeighbourDownTest.validationParticipentCrashesAndComesBack|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1704/testReport/junit/org.apache.cassandra.distributed.test/PreviewRepairCoordinatorNeighbourDownTest/validationParticipentCrashesAndComesBack_SEQUENTIAL_true__2/]).
The fix looks good to me.
Submitted one full run to check if failures are fixed:
* https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1729/
> Expired snapshots of dropped tables are not removed after node restart
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-17619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17619
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Priority: Normal
> Fix For: 4.1-beta
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Expired TTL snapshots from a dropped table are only removed if the node is
> not restarted after the table is dropped.
> The reason for this is because {{SnapshotManager}} is using the old
> implementation of {{listsnapshots}} to load snapshots in memory during node
> startup, before CASSANDRA-16843 is fixed so it doesn't keep track of
> snapshots of dropped tables.
> We should make {{SnapshotManager}} use the new implementation to load
> snapshots of dropped tables in memory, what ensures they will be removed when
> expired.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
