[
https://issues.apache.org/jira/browse/CASSANDRA-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540921#comment-17540921
]
Stefan Miklosovic commented on CASSANDRA-17619:
-----------------------------------------------
[~paulo] there is still this (1). There is one more case of this faulty
comparision later in that method. Do not you have your IDEA set up in such a
way that it will automatically hightlight this?
{code}
return subdir.getFileName().equals(Directories.BACKUPS_SUBDIR)
? FileVisitResult.SKIP_SUBTREE
: FileVisitResult.CONTINUE;
{code}
I will fix it as part of this patch. It is very minor bug which will just scan
backup dirs but they should not be.
(1) https://github.com/apache/cassandra/pull/1595#discussion_r861730641
> Expired snapshots of dropped tables are not removed after node restart
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-17619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17619
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Priority: Normal
> Fix For: 4.1-beta
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Expired TTL snapshots from a dropped table are only removed if the node is
> not restarted after the table is dropped.
> The reason for this is because {{SnapshotManager}} is using the old
> implementation of {{listsnapshots}} to load snapshots in memory during node
> startup, before CASSANDRA-16843 is fixed so it doesn't keep track of
> snapshots of dropped tables.
> We should make {{SnapshotManager}} use the new implementation to load
> snapshots of dropped tables in memory, what ensures they will be removed when
> expired.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
