[ 
https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580433#comment-17580433
 ] 

Stefan Miklosovic edited comment on CASSANDRA-13010 at 8/16/22 8:04 PM:
------------------------------------------------------------------------

PR: [https://github.com/apache/cassandra/pull/1791]
build: 
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1207/workflows/19676308-1a92-4b2d-a16a-ea8dad9054d5]

Below is the output from the test case to see this feature in action with some 
real-world load.

I renamed the flag to be "-v" or "--verbose". I am not completely sure if that 
is what we want but it seem to me it is better that "more info" flag before.

I am looking for a reviewer, [~rustyrazorblade] [~brandon.williams] would you 
please take a look if you dont mind and give me the feedback?

EDIT: pinging [~djoshi] and [~jjirsa] who are among the watchers as well, maybe 
they would be willing to spare 10 minutes on this? :)

{code:java}
pending tasks: 37
- keyspace_24.table_25: 1
- keyspace_24.table_26: 2
- keyspace_24.table_27: 1
- keyspace_24.table_28: 2
- keyspace_24.table_29: 1
- keyspace_00.table_01: 1
- keyspace_00.table_02: 2
- keyspace_00.table_03: 1
- keyspace_00.table_04: 2
- keyspace_00.table_05: 1
- keyspace_12.table_13: 1
- keyspace_12.table_14: 2
- keyspace_12.table_15: 1
- keyspace_12.table_16: 2
- keyspace_12.table_17: 1
- keyspace_06.table_10: 1
- keyspace_06.table_11: 2
- keyspace_06.table_07: 2
- keyspace_06.table_08: 1
- keyspace_06.table_09: 2
- keyspace_18.table_21: 2
- keyspace_18.table_22: 1
- keyspace_18.table_23: 2
- keyspace_18.table_19: 2
- keyspace_18.table_20: 1

id                                   compaction type                   keyspace 
   table    completed total  unit  progress
/my/data/dir0                                                                   
                                           
7e40e800-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_01 123       123456 bytes 0.10%   
7e70d1a0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_04 123       123456 bytes 0.10%   
7e529b40-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_02 123       123456 bytes 0.10%   
7e638b30-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_03 123       123456 bytes 0.10%   
7e7edb60-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_05 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir1                                                                   
                                           
7e9e9860-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_08 123       123456 bytes 0.10%   
7ecea910-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_11 123       123456 bytes 0.10%   
7ebf3fc0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_10 123       123456 bytes 0.10%   
7eaddaa0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_09 123       123456 bytes 0.10%   
7e8fcb50-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_07 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir2                                                                   
                                           
7ee194d0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_13 123       123456 bytes 0.10%   
7f1771e0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_17 123       123456 bytes 0.10%   
7f0b3ce0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_16 123       123456 bytes 0.10%   
7eef9e90-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_14 123       123456 bytes 0.10%   
7eff5600-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_15 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir3                                                                   
                                           
7f257ba0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_19 123       123456 bytes 0.10%   
7f305110-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_20 123       123456 bytes 0.10%   
7f3b2680-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_21 123       123456 bytes 0.10%   
7f4845e0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_22 123       123456 bytes 0.10%   
7f560180-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_23 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir4                                                                   
                                           
7f8575f0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_28 123       123456 bytes 0.10%   
7f91f910-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_29 123       123456 bytes 0.10%   
7f645960-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_25 123       123456 bytes 0.10%   
7f70dc80-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_26 123       123456 bytes 0.10%   
7f7b8ae0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_27 123       123456 bytes 0.10%   
                                                                                
                                           
-------- Other operations --------                                              
                                           
7f257ba0-1d9c-11ed-8f7d-0df44c673538 View build                        
keyspace_18 table_19 123       123456 bytes 0.10%   
7e8fcb50-1d9c-11ed-8f7d-0df44c673538 Scrub                             
keyspace_06 table_07 123       123456 bytes 0.10%   
7eaddaa0-1d9c-11ed-8f7d-0df44c673538 Secondary index build             
keyspace_06 table_09 123       123456 bytes 0.10%   
7f560180-1d9c-11ed-8f7d-0df44c673538 Validation                        
keyspace_18 table_23 123       123456 bytes 0.10%   
7eef9e90-1d9c-11ed-8f7d-0df44c673538 Verify                            
keyspace_12 table_14 123       123456 bytes 0.10%   
7f70dc80-1d9c-11ed-8f7d-0df44c673538 Row cache save                    
keyspace_24 table_26 123       123456 bytes 0.10%   
7f3b2680-1d9c-11ed-8f7d-0df44c673538 Relocate sstables to correct disk 
keyspace_18 table_21 123       123456 bytes 0.10%   
7f0b3ce0-1d9c-11ed-8f7d-0df44c673538 Stream                            
keyspace_12 table_16 123       123456 bytes 0.10%   
7e529b40-1d9c-11ed-8f7d-0df44c673538 Key cache save                    
keyspace_00 table_02 123       123456 bytes 0.10%   
7ecea910-1d9c-11ed-8f7d-0df44c673538 Unknown compaction type           
keyspace_06 table_11 123       123456 bytes 0.10%   
7f8575f0-1d9c-11ed-8f7d-0df44c673538 Cleanup                           
keyspace_24 table_28 123       123456 bytes 0.10%   
7e70d1a0-1d9c-11ed-8f7d-0df44c673538 Counter cache save                
keyspace_00 table_04 123       123456 bytes 0.10%   
Active compaction remaining time :        n/a
{code}




was (Author: smiklosovic):
PR: [https://github.com/apache/cassandra/pull/1791]
build: 
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1207/workflows/19676308-1a92-4b2d-a16a-ea8dad9054d5]

Below is the output from the test case to see this feature in action with some 
real-world load.

I renamed the flag to be "-v" or "--verbose". I am not completely sure if that 
is what we want but it seem to me it is better that "more info" flag before.

I am looking for a reviewer, [~rustyrazorblade] [~brandon.williams] would you 
please take a look if you dont mind and give me the feedback?

{code:java}
pending tasks: 37
- keyspace_24.table_25: 1
- keyspace_24.table_26: 2
- keyspace_24.table_27: 1
- keyspace_24.table_28: 2
- keyspace_24.table_29: 1
- keyspace_00.table_01: 1
- keyspace_00.table_02: 2
- keyspace_00.table_03: 1
- keyspace_00.table_04: 2
- keyspace_00.table_05: 1
- keyspace_12.table_13: 1
- keyspace_12.table_14: 2
- keyspace_12.table_15: 1
- keyspace_12.table_16: 2
- keyspace_12.table_17: 1
- keyspace_06.table_10: 1
- keyspace_06.table_11: 2
- keyspace_06.table_07: 2
- keyspace_06.table_08: 1
- keyspace_06.table_09: 2
- keyspace_18.table_21: 2
- keyspace_18.table_22: 1
- keyspace_18.table_23: 2
- keyspace_18.table_19: 2
- keyspace_18.table_20: 1

id                                   compaction type                   keyspace 
   table    completed total  unit  progress
/my/data/dir0                                                                   
                                           
7e40e800-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_01 123       123456 bytes 0.10%   
7e70d1a0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_04 123       123456 bytes 0.10%   
7e529b40-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_02 123       123456 bytes 0.10%   
7e638b30-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_03 123       123456 bytes 0.10%   
7e7edb60-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_00 table_05 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir1                                                                   
                                           
7e9e9860-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_08 123       123456 bytes 0.10%   
7ecea910-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_11 123       123456 bytes 0.10%   
7ebf3fc0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_10 123       123456 bytes 0.10%   
7eaddaa0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_09 123       123456 bytes 0.10%   
7e8fcb50-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_06 table_07 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir2                                                                   
                                           
7ee194d0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_13 123       123456 bytes 0.10%   
7f1771e0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_17 123       123456 bytes 0.10%   
7f0b3ce0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_16 123       123456 bytes 0.10%   
7eef9e90-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_14 123       123456 bytes 0.10%   
7eff5600-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_12 table_15 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir3                                                                   
                                           
7f257ba0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_19 123       123456 bytes 0.10%   
7f305110-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_20 123       123456 bytes 0.10%   
7f3b2680-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_21 123       123456 bytes 0.10%   
7f4845e0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_22 123       123456 bytes 0.10%   
7f560180-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_18 table_23 123       123456 bytes 0.10%   
                                                                                
                                           
/my/data/dir4                                                                   
                                           
7f8575f0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_28 123       123456 bytes 0.10%   
7f91f910-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_29 123       123456 bytes 0.10%   
7f645960-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_25 123       123456 bytes 0.10%   
7f70dc80-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_26 123       123456 bytes 0.10%   
7f7b8ae0-1d9c-11ed-8f7d-0df44c673538 Compaction                        
keyspace_24 table_27 123       123456 bytes 0.10%   
                                                                                
                                           
-------- Other operations --------                                              
                                           
7f257ba0-1d9c-11ed-8f7d-0df44c673538 View build                        
keyspace_18 table_19 123       123456 bytes 0.10%   
7e8fcb50-1d9c-11ed-8f7d-0df44c673538 Scrub                             
keyspace_06 table_07 123       123456 bytes 0.10%   
7eaddaa0-1d9c-11ed-8f7d-0df44c673538 Secondary index build             
keyspace_06 table_09 123       123456 bytes 0.10%   
7f560180-1d9c-11ed-8f7d-0df44c673538 Validation                        
keyspace_18 table_23 123       123456 bytes 0.10%   
7eef9e90-1d9c-11ed-8f7d-0df44c673538 Verify                            
keyspace_12 table_14 123       123456 bytes 0.10%   
7f70dc80-1d9c-11ed-8f7d-0df44c673538 Row cache save                    
keyspace_24 table_26 123       123456 bytes 0.10%   
7f3b2680-1d9c-11ed-8f7d-0df44c673538 Relocate sstables to correct disk 
keyspace_18 table_21 123       123456 bytes 0.10%   
7f0b3ce0-1d9c-11ed-8f7d-0df44c673538 Stream                            
keyspace_12 table_16 123       123456 bytes 0.10%   
7e529b40-1d9c-11ed-8f7d-0df44c673538 Key cache save                    
keyspace_00 table_02 123       123456 bytes 0.10%   
7ecea910-1d9c-11ed-8f7d-0df44c673538 Unknown compaction type           
keyspace_06 table_11 123       123456 bytes 0.10%   
7f8575f0-1d9c-11ed-8f7d-0df44c673538 Cleanup                           
keyspace_24 table_28 123       123456 bytes 0.10%   
7e70d1a0-1d9c-11ed-8f7d-0df44c673538 Counter cache save                
keyspace_00 table_04 123       123456 bytes 0.10%   
Active compaction remaining time :        n/a
{code}



> nodetool compactionstats should say which disk a compaction is writing to
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13010
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Local/Compaction, Tool/nodetool
>            Reporter: Jon Haddad
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>              Labels: 4.0-feature-freeze-review-requested
>             Fix For: 4.x
>
>         Attachments: cleanup.png, multiple operations.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to