[
https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603158#comment-17603158
]
Brandon Williams edited comment on CASSANDRA-17885 at 9/12/22 3:44 PM:
-----------------------------------------------------------------------
Cherry picking the patch applies cleanly in
[2.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17885-2.1] and
[2.2|https://github.com/driftx/cassandra/tree/CASSANDRA-17885-2.2]. For 2.0,
we'd have to backport CASSANDRA-7028 also so we can compile. That is probably
too much effort for so little gain, so I looked at the tests that utilize 2.0
and I think there are only two: one in
[counter_test.py|https://github.com/apache/cassandra-dtest/blob/trunk/counter_test.py#L34]
and one in
[secondary_index_test.py|https://github.com/apache/cassandra-dtest/blob/trunk/secondary_indexes_test.py#L1103]
but that one is a dead test now that only runs against 2.1, so it's really
just the counter test_13691 that needs it.
was (Author: brandon.williams):
Cherry picking the patch applies cleanly in
[2.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17885-2.1] and
[2.2|https://github.com/driftx/cassandra/tree/CASSANDRA-17885-2.2]. For 2.0,
we'd have to backport CASSANDRA-7028 also so we can compile. That is probably
too much effort for so little gain, so I looked at the tests that utilize 2.0
and I think there are only two: one in
[counter_test.py:https://github.com/apache/cassandra-dtest/blob/trunk/counter_test.py#L34]
and one in
[secondary_index_test.py|https://github.com/apache/cassandra-dtest/blob/trunk/secondary_indexes_test.py#L1103]
but that one is a dead test now that only runs against 2.1, so it's really
just the counter test_13691 that needs it.
> Backport CASSANDRA-17581 to older branches for tests
> ----------------------------------------------------
>
> Key: CASSANDRA-17885
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17885
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 2.1.x, 2.2.x, 2.0.x
>
>
> Some of our tests use old branches for the purposes of testing upgrades and
> behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on
> nodetool with a modern JDK. We can port this fix to those branches and
> adjust the tests to use the newest version of them to solve this going
> forward.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
