[
https://issues.apache.org/jira/browse/CASSANDRA-17885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603646#comment-17603646
]
Brandon Williams edited comment on CASSANDRA-17885 at 9/13/22 4:03 PM:
-----------------------------------------------------------------------
[Here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-17885] is a
branch that adds a function that hacks the nodetool script, simply adding a -D
for legacy parsing in the right place toward the end, and then using that
function in the cases where set_install_dir is pointed at a version that
doesn't have CASSANDRA-17581. And
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/635/workflows/b3a44ef1-0680-4e61-bff4-48337b761ccb]
is a circle run to smoke test it, since that code isn't actually needed when
running inside the docker image with the old JDK.
was (Author: brandon.williams):
[Here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-17885] is a
branch that adds a function that hacks the nodetool script, simply adding a -D
for legacy parsing in the right place toward the end, and then using that
function in the cases where set_install_dir is pointed at a version that
doesn't have CASSANDRA-17581. And
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/635/workflows/165205b0-8656-43a7-96b2-3ec87dd87bc0]
is a circle run to smoke test it, since that code isn't actually needed when
running inside the docker image with the old JDK.
> Backport CASSANDRA-17581 to older branches for tests
> ----------------------------------------------------
>
> Key: CASSANDRA-17885
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17885
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 2.1.x, 2.2.x, 2.0.x
>
>
> Some of our tests use old branches for the purposes of testing upgrades and
> behavior in mixed versions, but those lacking CASSANDRA-17581 will fail on
> nodetool with a modern JDK. We can port this fix to those branches and
> adjust the tests to use the newest version of them to solve this going
> forward.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]