[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615250#comment-17615250
]
Josh McKenzie commented on CASSANDRA-17939:
-------------------------------------------
First high level thoughts from a UX / design perspective / comments on the
thread:
{quote}This ticket is focused only on JUnit tests.
{quote}
+1 to junit only; we should be avoiding adding new python tests anyway at this
point. I see you've added repeat python tests as well which I wouldn't say _no_
to. :)
{quote}Locally, you can run the same simple git command
{quote}
Could we wrap this up in a flag to generate.sh in .circleci, {{generate.sh -d}}
or something to show auto-detected diff tests? Or at least doc how circle
derives it in readme.md so folks can run that themselves locally if they're
curious what tests get picked up and want to perhaps add some more.
{quote}There was a request on the Mailing List to keep this one on hold for a
bit.
{quote}
This was mostly miscommunication and a race condition between mck and I. Didn't
want to derail / confuse the 4.1-beta1 vote w/another vote. Think we're good to
go here.
{quote}we don't have regular not-multiplexer jobs for some Ant targets, like
test-cdc or msg-ser-test
{quote}
No concerns about this, though we may want to doc in readme.md
{quote}I wonder if we should remove the classic utest multiplexer from the
pre-commit workflows and leave it only on the separate workflows
{quote}
+1 to moving to separate workflows only in favor of the new flow
Going to start digging into the changes + the UX on circle now. Thanks for
doing all this Andres - this is going to be a _huge_ help for a lot of folks!
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
