[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620179#comment-17620179
]
Berenguer Blasi commented on CASSANDRA-17964:
---------------------------------------------
Hi [~stefan.miklosovic]. We have 2 options:
A. Use your regexp + a few renames: That is fine, but it will not catch some
future violations.
B. Use my regexp + a few more renames: That will catch all present and future
offenders. The restriction is only tests can contain the word 'Test' in the
filename. All others will have to be renamed. My suggestion is to rename those
to *Tester* which my regexp is fine with.
I don't think both options are exclusive, we can open a ticket for B if we see
with time A didn't suffice. Wdyt is best?
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
