[
https://issues.apache.org/jira/browse/CASSANDRA-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622688#comment-17622688
]
Ekaterina Dimitrova edited comment on CASSANDRA-17240 at 10/22/22 7:47 PM:
---------------------------------------------------------------------------
My understanding is we need to be at least able to run all jobs in both
CircleCI and Jenkins and all JDKs. Now whether mandatory or not I think it is a
second question and of course important one.
I'd say at least adding them as opportunity to be able to run them in CircleCI
J11 is a thing now. The variations of j8 unit tests are also not mandatory. The
work in this ticket is quite big and adding j8 jobs here as a start is ok IMHO.
I just think we need to ensure there is a follow up ticket to add those also in
Jenkins (thanks for pointing it, I missed that) and also to JDK11. This on its
own is also already a work that requires its time and effort too. I can totally
see that. I'd suggest probably until we have those tests in Jenkins, to make
them mandatory in CircleCI, same as we did with others like _system_keyspace_
and the _simulator_ ones so we do not see regressions in time (we did see
regressions happening with those two mentioned suites and that was the reason
we made them mandatory in CircleCI until they get added in Jenkins)
was (Author: e.dimitrova):
My understanding is we need to be at least able to run all jobs in both
CircleCI and Jenkins and all JDKs. Now whether mandatory or not I think it is a
second question and of course important one.
I'd say at least adding them as opportunity to be able to run them in CircleCI
J11 is a thing now. The variations of j8 unit tests are also not mandatory. The
work in this ticket is quite big and adding j8 jobs here as a start is ok IMHO.
I just think we need to ensure there is a follow up ticket to add those also in
Jenkins (thanks for pointing it, I missed that) and also to JDK11. This on its
own is also already a work that requires its time and effort too. I can totally
see that. I'd suggest probably until we have those tests in Jenkins, to make
them mandatory in CircleCI, same as we did with others like _system_keyspace_
and the _simulator_ ones so we do not see regressions in time (we did see it
with those two mentioned suites and that was the reason we made them mandatory
in CircleCI until they get added in Jenkins)
> CEP-19: Trie memtable implementation
> ------------------------------------
>
> Key: CASSANDRA-17240
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17240
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Memtable
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
> Priority: Normal
> Fix For: 4.2
>
> Attachments: SkipListMemtable-OSS.png, TrieMemtable-OSS.png,
> density_SG.html.gz, density_test_with_sharding.html.gz, latency-1_1-95.png,
> latency-9_1-95.png, throughput_SG.png, throughput_apache.png
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
> Trie-based memtable implementation as described in CEP-19, built on top of
> CASSANDRA-17034 and CASSANDRA-6936.
> The implementation is available in this
> [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17240].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
