[ 
https://issues.apache.org/jira/browse/CASSANDRA-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620982#comment-17620982
 ] 

Andres de la Peña edited comment on CASSANDRA-17240 at 10/20/22 10:14 AM:
--------------------------------------------------------------------------

It seems there are a couple of missing details in the CircleCI files:

* In {{.circleci/config-2_1.yml}}, adding the new {{test-trie}} Ant target to 
the {{run_repeated_utests}} command.
* In {{.circleci/generate.sh}}, removing the {{utests_trie_repeat}} job if 
there aren't utests to be repeated.

[This 
commit|https://github.com/adelapena/cassandra/commit/f23f64db3c2818bd3c2e693c4c67802f9dd7a195]
 contains fixes for those two things, and the regenerated default config.

The {{s/MemtableTrie/InMemoryTrie/}} rename looks good to me, indeed it was a 
bit tricky to distinguish between {{MemtableTrie}} and {{TrieMemtable}}.


was (Author: adelapena):
It seems there are a couple of missing details in the CircleCI:

* In {{.circleci/config-2_1.yml}}, adding the new {{test-trie}} Ant target to 
the {{run_repeated_utests}} command.
* In {{.circleci/generate.sh}}, removing the {{utests_trie_repeat}} job if 
there aren't utests to be repeated.

[This 
commit|https://github.com/adelapena/cassandra/commit/f23f64db3c2818bd3c2e693c4c67802f9dd7a195]
 contains fixes for those two things, and the regenerated default config.

The {{s/MemtableTrie/InMemoryTrie/}} rename looks good to me, indeed it was a 
bit tricky to distinguish between {{MemtableTrie}} and {{TrieMemtable}}.

> CEP-19: Trie memtable implementation
> ------------------------------------
>
>                 Key: CASSANDRA-17240
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17240
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Memtable
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Normal
>         Attachments: SkipListMemtable-OSS.png, TrieMemtable-OSS.png, 
> density_SG.html.gz, density_test_with_sharding.html.gz, latency-1_1-95.png, 
> latency-9_1-95.png, throughput_SG.png, throughput_apache.png
>
>          Time Spent: 13h 20m
>  Remaining Estimate: 0h
>
> Trie-based memtable implementation as described in CEP-19, built on top of 
> CASSANDRA-17034 and CASSANDRA-6936.
> The implementation is available in this 
> [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-17240].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to