[ 
https://issues.apache.org/jira/browse/CASSANDRA-16491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625263#comment-17625263
 ] 

Caleb Rackliffe edited comment on CASSANDRA-16491 at 10/27/22 7:15 PM:
-----------------------------------------------------------------------

+1

Just need to find a second committer to review now. Also, I'll start a CircleCI 
run w/ a clone of your branch shortly...


was (Author: maedhroz):
+1

Just need to find a second committer now. Also, I'll start a CircleCI run w/ a 
clone of your branch shortly...

> nodetool bootstrap resume returns success even if there is an error during 
> bootstrap
> ------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16491
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16491
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: Caleb Rackliffe
>            Assignee: Leonard Ma
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> "nodetool bootstrap resumeā€ prints a relevant error message if the operation 
> fails, but it then proceeds to return a normal error code. It ignores the 
> ProgressEventType.ERROR message that arrives before COMPLETE. This also 
> happens when we handle failed connections. BootstrapMonitor should at least 
> track whether or not it has seen an error, which would allow us to throw when 
> one occurs after signaling, and therefore to inform callers.
> Trunk PR: [https://github.com/apache/cassandra/pull/1949]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to