[ 
https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627200#comment-17627200
 ] 

Josh McKenzie commented on CASSANDRA-17768:
-------------------------------------------

Chatting w/Mick offline about this. I'm a little concerned about folks running 
in environments w/insufficient or weird TCP_KEEPALIVE that might not realize it 
until they upgrade to 4.1 and start having streams / channels that get killed 
for inactivity.

While it's certainly redundant in a world w/expected tcp env, and less of a 
concern on a single channel vs. the older paradigm, what's the downside to us 
reinstating the {{KeepAliveTask}} scheduling code from 4.0 in 4.1 defaulted to 
on? I have to assume the volume of messaging from this would be negligible and 
historically channels getting closed for inactivity has been a niggling 
annoyance for us, so a little redundancy in this area of our communications 
would be welcome IMO.

> streaming_keep_alive_period is not used after [CASSANDRA-16927] CEP-10 Phase 
> 1: Refactor Streaming
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17768
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17768
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Streaming and Messaging
>            Reporter: Ekaterina Dimitrova
>            Assignee: Aleksey Yeschenko
>            Priority: Normal
>             Fix For: 4.1-rc, 4.1.x, 4.x
>
>
> While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10 
> Phase 1: Refactor Streaming 
> streaming_keep_alive_period is not used anymore, except to print it in error 
> message 
> [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689]
> If the property should not be used anymore, we need to deprecate it and fix 
> the error message as it is misleading.
> [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of 
> this one as authors of that patch?
> Thank you in advance!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to