[
https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632336#comment-17632336
]
Andres de la Peña commented on CASSANDRA-18001:
-----------------------------------------------
{quote}Comments addressed and patch finished for [3.0
|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18001-3.0-2-mid]
(or at least I hoped I was done)
{quote}
Looks great, I have left a couple of minor nits in the commit.
{quote}Unfortunately, I discovered that CASSANDRA-18000 broke the long unit
tests and it also breaks now the burn tests.
{quote}
I think the problem is that {{ant clean}} is used in combination with
{{-Dno-build-test=true}}
[here|https://github.com/apache/cassandra/blob/cassandra-3.0/.circleci/config-2_1.yml#L776].
The reason for that {{clean}} is mentioned
[here|https://github.com/apache/cassandra/blob/cassandra-3.0/.circleci/config-2_1.yml#L767-L768],
although that doesn't seem to make sense for 3.0 since Java 11 is not used.
Also, it seems that the {{clean}} is not used in 3.11, 4.0, 4.1 nor trunk,
although the comment about it is present in all branches. I wonder if we should
be running {{clean}} in those branches, or the comment is wrong.
{quote}I tried locally and in CI without my patch. I guess it wasn't noticed up
to now as those are not mandatory pre-commit.
{quote}
Indeed I didn't run long unit tests on all branches during CASSANDRA-18000, and
I should have. But I [ran them for
trunk|https://app.circleci.com/pipelines/github/adelapena/cassandra/2370/workflows/29e394c4-d76f-43df-a011-57dd5727e890]
and it passed, probably because of the absent {{{}clean{}}}.
> Add missing tests suites to CircleCI
> ------------------------------------
>
> Key: CASSANDRA-18001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18001
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> Burn tests to all branches, large Python DTests (with/without vnodes),
> cqlshlib not tested in all branches and with all jdks; Java distributed tests
> not running with J8/J11 4.0+
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
