[ 
https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632571#comment-17632571
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18001 at 11/11/22 11:14 PM:
----------------------------------------------------------------------------

So burn tests are solved by removing clean as suggested by Andres. Regarding 
the large tests, [~adelapena] spotted a bug in the split command where if we 
provide more containers than we have test classes, CircleCI will run all DTests 
in the containers that receive an empty split.

I fixed this to fail those containers with a message for the user - 
{code:java}
Tune your parallelism, there are more containers then test classes. Nothing to 
do in this container{code}
We would need 35 containers for the large DTests in theory at max, so I got 36 
containers with low resources and started the tests - [this is how a spare 
container would fail now 
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2083/workflows/20a7da50-8b96-4829-84db-7b80fd94034d/jobs/16455/parallel-runs/35?filterBy=ALL].
 (the rest are failures as I didn't want to waste higher resources and run all 
tests). I also tuned the large DTests to run on 4 large containers. There are 
two tests that fail because there are not enough resources to bring up 9 nodes. 
Spinning a 2X Large container for all large tests because of 2 is not 
justified. 

Also noticed that DTests for 3.0 and 3.11 run with 32 and not 16 tokens. I will 
open a follow up ticket where we fix that and add a one stop parameter for the 
number of tokens for all DTests per branch. 

I suggest we commit those two tests failing but open a follow up ticket where 
we can pull them in a bigger container and additional job or just remove them 
and document that we rely on Jenkins for them (I checked they run and pass 
there). That will require probably some annotation to be added for them.

I want us now to unblock 4.1 here

I will propagate now the patches to all branches and add the missing Cython 
CQLSHLIB tests in 4.0, 4.1 and trunk now when CASSANDRA-18028 and 
CASSANDRA-18036 are closed. I will open a follow up ticket for adding the 
CQLSHLIB tests for previous branches.  

*EDIT:* I will also tune the Large Dtests to run with X Large 1 container in 
HIGHRES. The 4 Large containers are for MID resources configuration

 


was (Author: e.dimitrova):
So burn tests are solved by removing clean as suggested by Andres. Regarding 
the large tests, [~adelapena] spotted a bug in the split command where if we 
provide more containers than we have test classes, CircleCI will run all DTests 
in the containers that receive an empty split.

I fixed this to fail those containers with a message for the user - 
{code:java}
Tune your parallelism, there are more containers then test classes. Nothing to 
do in this container{code}
We would need 35 containers for the large DTests in theory at max, so I got 36 
containers with low resources and started the tests - [this is how a spare 
container would fail now 
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2083/workflows/20a7da50-8b96-4829-84db-7b80fd94034d/jobs/16455/parallel-runs/35?filterBy=ALL].
 (the rest are failures as I didn't want to waste higher resources and run all 
tests). I also tuned the large DTests to run on 4 large containers. There are 
two tests that fail because there are not enough resources to bring up 9 nodes. 
Spinning a 2X Large container for all large tests because of 2 is not 
justified. 

Also noticed that DTests for 3.0 and 3.11 run with 32 and not 16 tokens. I will 
open a follow up ticket where we fix that and add a one stop parameter for the 
number of tokens for all DTests per branch. 

I suggest we commit those two tests failing but open a follow up ticket where 
we can pull them in a bigger container and additional job or just remove them. 
That will require probably some annotation to be added for them.

I want us now to unblock 4.1 here

I will propagate now the patches to all branches and add the missing Cython 
CQLSHLIB tests in 4.0, 4.1 and trunk now when CASSANDRA-18028 and 
CASSANDRA-18036 are closed. I will open a follow up ticket for adding the 
CQLSHLIB tests for previous branches.  

*EDIT:* I will also tune the Large Dtests to run with X Large 1 container in 
HIGHRES. The 4 Large containers are for MID resources configuration

 

> Add missing tests suites to CircleCI
> ------------------------------------
>
>                 Key: CASSANDRA-18001
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18001
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Urgent
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc, 4.1.x, 4.x
>
>
> Burn tests to all branches, large Python DTests (with/without vnodes), 
> cqlshlib not tested in all branches and with all jdks; Java distributed tests 
> not running with J8/J11 4.0+



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to