[ 
https://issues.apache.org/jira/browse/CASSANDRA-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650837#comment-17650837
 ] 

maxwellguo edited comment on CASSANDRA-18061 at 12/28/22 8:07 AM:
------------------------------------------------------------------

[~smiklosovic]Thanks very much.
Sorry for offline these days , I think what I did was inappropriate ,next time 
I should contact you after modifying the code and passing the test,not 
immediately after the modification.
I have already fix the exception what occurs at java-jvm-dtest.
My ci test is ok at this test case in  upgrade tests  for java8 preommit 
:https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/355/workflows/5e9a984a-3dd1-43a3-8347-832918a0f1c1
commit pr: https://github.com/apache/cassandra/pull/2047/commits


was (Author: maxwellguo):
[~smiklosovic]Thanks very much.
Sorry for offline these days , I think what I did was inappropriate ,next time 
I should contact you after modifying the code and passing the test,not 
immediately after the modification.
I have already fix the exception what occurs at java-jvm-dtest.
My ci test is ok at this test case in  upgrade tests  for java8 preommit 
:https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/355/workflows/5e9a984a-3dd1-43a3-8347-832918a0f1c1

> Add compaction type output result for nodetool compactionhistory
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-18061
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18061
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Compaction, Tool/nodetool
>            Reporter: maxwellguo
>            Assignee: maxwellguo
>            Priority: Low
>             Fix For: 4.x
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> If we want to see whether we have made a compaction and what kind of 
> compaction we have done for this node, we may go to see the 
> compaction_history system table for some deftails or use nodetool 
> compactionhistory command , But I found that the table do not specify the 
> compaction type so does the compactionhistory command too, like index build , 
> compaction type, clean or scrub for this node. So I think may be it is need 
> to add a type of compaction column to specify the compaction tpe for 
> system.compaction_history and so we can get the type of compaction through 
> system.compaction_history table or nodetool compactionhistory to see whether 
> we have made a major compact for this node  .:)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to