[
https://issues.apache.org/jira/browse/CASSANDRA-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656433#comment-17656433
]
maxwellguo edited comment on CASSANDRA-18061 at 1/10/23 5:57 AM:
-----------------------------------------------------------------
Thanks [~smiklosovic] , New test with 3.x was update now . and java8 precommit
jvm-upgrade-dtest is green :
https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/362/workflows/e9b6a349-3d7d-4b50-9018-e407e584be8f
commit change :
https://github.com/apache/cassandra/pull/2047/files#diff-ad515f26e664fe1525daf7c6388fe1a66a853bd389c350cd39c76aed8e121d43R47
And I check the git history of SystemKeyspace.java , some system table also add
new regular column (not primary key).,But SystemKeyspaceMigrator is not added .
But if the system column type change I think SystemKeyspaceMigiration is still
need,For this case Only a new column is added , and if the column is selected
and null is returned ,and for nodetool compactionhistory if older version do
not have this column , UNKNOW will return ,I think the backward compatibility
has been done. And the ut
test/distributed/org/apache/cassandra/distributed/upgrade/CompactionHistorySystemTableUpgradeTest.java
Have already test the case of the backward compatibility
[~brandon.williams][~mck]
[~jlewandowski] I saw SystemKeyspaceMigrator41 was added by you . And it seems
[~aweisberg] have add many columns to system keyspace tables . So can you help
with this too ? I just add a new regular column to compaction_history system
table.
So should it doing some migration for system keyspace data just like some
system keyspace in SystemKeyspaceMigrator41 ?I think there is no need but
should handle backward compatibility
was (Author: maxwellguo):
[~smiklosovic] New test with 3.x was update now . and java8 precommit
jvm-upgrade-dtest is green :
https://app.circleci.com/pipelines/github/Maxwell-Guo/cassandra/362/workflows/e9b6a349-3d7d-4b50-9018-e407e584be8f
commit change :
https://github.com/apache/cassandra/pull/2047/files#diff-ad515f26e664fe1525daf7c6388fe1a66a853bd389c350cd39c76aed8e121d43R47
And I check the git history of SystemKeyspace.java , some system table also add
new regular column (not primary key).,But SystemKeyspaceMigrator is not added .
But if the system column type change I think SystemKeyspaceMigiration is still
need,For this case Only a new column is added , and if the column is selected
and null is returned ,and for nodetool compactionhistory if older version do
not have this column , UNKNOW will return ,I think the backward compatibility
has been done.
[~brandon.williams][~mck]
[~jlewandowski] I saw SystemKeyspaceMigrator41 was added by you . And it seems
[~aweisberg] have add many columns to system keyspace tables . So can you help
with this too ? I just add a new regular column to compaction_history system
table.
So should it doing some migration for system keyspace data just like some
system keyspace in SystemKeyspaceMigrator41 ?I think there is no need but
should handle backward compatibility
> Add compaction type output result for nodetool compactionhistory
> ----------------------------------------------------------------
>
> Key: CASSANDRA-18061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18061
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Tool/nodetool
> Reporter: maxwellguo
> Assignee: maxwellguo
> Priority: Low
> Fix For: 4.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> If we want to see whether we have made a compaction and what kind of
> compaction we have done for this node, we may go to see the
> compaction_history system table for some deftails or use nodetool
> compactionhistory command , But I found that the table do not specify the
> compaction type so does the compactionhistory command too, like index build ,
> compaction type, clean or scrub for this node. So I think may be it is need
> to add a type of compaction column to specify the compaction tpe for
> system.compaction_history and so we can get the type of compaction through
> system.compaction_history table or nodetool compactionhistory to see whether
> we have made a major compact for this node .:)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
