[
https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656768#comment-17656768
]
David Capwell commented on CASSANDRA-16325:
-------------------------------------------
Saw this due to CASSANDRA-18110 and the vtable work. Looking at the patch I
have 2 main questions:
1) why embed into the calls when we get progress events providing the same
details, just batched for every 64k bytes? Using the stream listens we have
would resolve [~jmckenzie] comments as they are every 64k; this also
drastically shrinks the size and scope of this patch as its just adding a
single listener and listening to the FILE_PROGRESS event.
2) it seems that most of this work is to boil down to calling 2 lines:
https://github.com/apache/cassandra/pull/2058/files#diff-bc79ba735741b3d997c735ad38ea4793d079d3ca2f2162412a422f26b3efdb40R99-R100.
This work has a lot of overlap with the stream vtable which does the same
work, just using the events rather than embedding into the call sites; should
we move these counters there?
> Update streaming metrics incrementally
> --------------------------------------
>
> Key: CASSANDRA-16325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16325
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Paulo Motta
> Assignee: Isaac Reath
> Priority: Normal
> Labels: lhf
> Fix For: 4.2
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> Currently the inbound and outbound streamed bytes metrics are incremented
> after each file is streamed, what doesn't represent the current number of
> bytes streamed since it can take a long time for a large file to be streamed.
> We should update the metric incrementally as data is streamed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
