[ 
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17668593#comment-17668593
 ] 

Stefan Miklosovic commented on CASSANDRA-17964:
-----------------------------------------------

I went through the branches, rebased all of them etc ... they are bellow. 
Nothing important has changed in the meanwhile.

3.0 https://github.com/apache/cassandra/pull/1981
3.11 https://github.com/apache/cassandra/pull/1982
4.0 https://github.com/apache/cassandra/pull/1983
4.1 https://github.com/apache/cassandra/pull/1988
trunk https://github.com/apache/cassandra/pull/1990

Could I please get one more time +1 from you or am I free to just run the 
builds yet again and merge it? I do not want to do the builds before you 
review, if you do, as I would have to run them again if we find something is 
wrong. [~bereng] [~dcapwell]

> Some tests are never executed due to naming violation - fix it and add 
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17964
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/unit
>            Reporter: Ruslan Fomkin
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
>  doesn't follow naming convention to be run as unit tests and, thus, is never 
> run.
> The rule in build expects names as `*Test`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to