[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676714#comment-17676714
]
David Capwell commented on CASSANDRA-17964:
-------------------------------------------
[~bereng], [~stefan.miklosovic], I think the issue with removing the annotation
is we need to make those tests running and successful... For the *Example tests
I think this is fine, maybe it is best we run them always to make sure the
examples don't get stale...
The *Bench tests will fail 100% of the time in CI... I am in trunk and ran
GcCompactionBench, each test takes 1m (will be slower in CI) and each fails...
This will have the side effect of adding failing tests and causing the JVM to
timeout due to our unit test limit being smaller than the runtime of these
tests.
So, for the *Bench tests, I think we need a solution other than rename if we
drop the annotation... We either do NOT want to run them in CI, or fix (but
wouldn't want to put that burden on [~stefan.miklosovic])... Maybe use the
@Ignore annotation? I don't like this as it will still take resources in CI,
but only 2 files are impacted so prob wouldn't notice the impact
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
