[ 
https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679644#comment-17679644
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 1/22/23 8:55 PM:
--------------------------------------------------------------------------

 
{quote}What will break is where scripts/tools grep the build.xml for 
CASSANDRA_USE_JDK11 as a way to detect if jdk11 is possible.
{quote}
Yes, thanks for bearing with me. Indeed, this issue you already solved in 
CASSANDRA-17869 so my understanding is we need to block this ticket on the 
commit of CASSANDRA-17869.

Quick grep of the current CCM master branch confirmed we do not grep it in CCM:
{code:java}
$ grep -r "CASSANDRA_USE_JDK11" *
Binary file ccmlib/__pycache__/common.cpython-310.pyc matches
Binary file ccmlib/__pycache__/common.cpython-38.pyc matches
ccmlib/common.py:        if 'CASSANDRA_USE_JDK11' not in os_env:
Binary file tests/__pycache__/test_lib.cpython-310.pyc matches
Binary file tests/__pycache__/test_lib.cpython-38-PYTEST.pyc matches
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
Binary file tests/test_lib.pyc matches
Binary file tests/ccmlib/__pycache__/common.cpython-310.pyc matches
tests/ccmlib/common.py:        if 'CASSANDRA_USE_JDK11' not in os_env:
{code}


was (Author: e.dimitrova):
 
{quote}What will break is where scripts/tools grep the build.xml for 
CASSANDRA_USE_JDK11 as a way to detect if jdk11 is possible.
{quote}
Yes, thanks for bearing with me. Indeed, his issue you already solved in 
CASSANDRA-17869 so my understanding is we need to block this ticket on the 
commit of CASSANDRA-17869.

Quick grep of the current CCM master branch confirmed we do not grep it in CCM:
{code:java}
$ grep -r "CASSANDRA_USE_JDK11" *
Binary file ccmlib/__pycache__/common.cpython-310.pyc matches
Binary file ccmlib/__pycache__/common.cpython-38.pyc matches
ccmlib/common.py:        if 'CASSANDRA_USE_JDK11' not in os_env:
Binary file tests/__pycache__/test_lib.cpython-310.pyc matches
Binary file tests/__pycache__/test_lib.cpython-38-PYTEST.pyc matches
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
tests/test_lib.py:                                          
os_env={'CASSANDRA_USE_JDK11': 'true'})
Binary file tests/test_lib.pyc matches
Binary file tests/ccmlib/__pycache__/common.cpython-310.pyc matches
tests/ccmlib/common.py:        if 'CASSANDRA_USE_JDK11' not in os_env:
{code}

> Update current trunk build.xml and conf scripts for JDK17
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-18179
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18179
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 4.x
>
>
> To support JDK17 we need to make changes to build.xml and our scripts. There 
> is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 
> but it will need a change considering CASSANDRA-18133
> CC [~mck] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to