[ 
https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679647#comment-17679647
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 1/22/23 9:27 PM:
--------------------------------------------------------------------------

{quote}The 17869 patch changes ci-cassandra.a.o to test 11+17 on trunk, so it 
needs to wait til 17 tests pass.
{quote}
Yeah, I meant it with the assumption we add a toggle and change things 
incrementally as we were discussing on the ticket whether we want that or not. 
(to be discussed and decided) In the current state directly switching to 11+17, 
indeed, this won't work.
{quote}Quick work around is to add a mention of CASSANDRA_USE_JDK11 in a 
comment in this ticket's patch.
{quote}
That should probably work (let's test) if we really want to have this committed 
now despite we are not being able to still compile and run CI (even with still 
broken tests) until CASSANDRA-17281 lands. It seems that will unblock 
CASSANDRA-18133 but not JDK17 broader testing (people still need to at least 
comment out the scripted UDFs related classes in their branches)


was (Author: e.dimitrova):
{quote}The 17869 patch changes ci-cassandra.a.o to test 11+17 on trunk, so it 
needs to wait til 17 tests pass.
{quote}
Yeah, I meant it with the assumption we add a toggle and change things 
incrementally as we were discussing on the ticket whether we want that or not. 
(to be discussed and decided) In the current state directly switching to 11+17, 
indeed, this won't work.
{quote}Quick work around is to add a mention of CASSANDRA_USE_JDK11 in a 
comment in this ticket's patch.
{quote}
That should probably work (let's test) if we really want to have this committed 
now despite we are not being able to still compile and run CI (even with still 
broken tests) until CASSANDRA-17281 lands. It seems that will unblock 
CASSANDRA-18133 but not JDK17 broader testing (people still need to at least 
comment out the scripted UDF related classes in their branches)

> Update current trunk build.xml and conf scripts for JDK17
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-18179
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18179
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Michael Semb Wever
>            Priority: Normal
>             Fix For: 4.x
>
>
> To support JDK17 we need to make changes to build.xml and our scripts. There 
> is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 
> but it will need a change considering CASSANDRA-18133
> CC [~mck] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to