[
https://issues.apache.org/jira/browse/CASSANDRA-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679758#comment-17679758
]
Stefan Miklosovic commented on CASSANDRA-13460:
-----------------------------------------------
I have yet again rebased againt the current trunk and I improved the PR. The
previous version was changing the API in such a way that implementations of
loggers had a configuration object instead of hash map of properties. This is
now changed and it is backward compatible with what is there currently. I
simplified the PR as well.
It would be really great to look into this so we have a possibility to put
diagnostic events into bin log for further inspection.
The refactoring of the code is also making whole (bin) logger stuff more
aligned with everything else and it seems to be way more robust.
The current PR below also introduces three nodetool commands (enabled / disable
/ get diagnostics log options). As there is in general the trend of not
introducing new commands, I am happy to omit these commands to make the PR even
simpler and it would be configurable only via JMX.
[~marcuse] do you think this is something which might appear in 5.0? We missed
4.1 release ... unfortunately.
https://github.com/instaclustr/cassandra/commits/CASSANDRA-13460
> Diag. Events: Add local persistency
> -----------------------------------
>
> Key: CASSANDRA-13460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13460
> Project: Cassandra
> Issue Type: Sub-task
> Components: Legacy/Observability
> Reporter: Stefan Podkowinski
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.x
>
> Attachments: 0001-Add-persistency-for-events-to-system-keyspace.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some generated events will be rather less frequent but very useful for
> retroactive troubleshooting. E.g. all events related to bootstraping and
> gossip would probably be worth saving, as they might provide valuable
> insights and will consume very little resources in low quantities. Imaging if
> we could e.g. in case of CASSANDRA-13348 just ask the user to -run a tool
> like {{./bin/diagdump BootstrapEvent}} on each host, to get us a detailed log
> of all relevant events- provide a dump of all events as described in the
> [documentation|https://github.com/spodkowinski/cassandra/blob/WIP-13460/doc/source/operating/diag_events.rst].
>
> This could be done by saving events white-listed in cassandra.yaml to a local
> table. Maybe using a TTL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
